Skip to content

Avoid conditional jump that depends on uninitialized memory - #16052

Merged
acolombier merged 1 commit into
mixxxdj:2.5from
daschuer:valgrind_columncache
Mar 1, 2026
Merged

Avoid conditional jump that depends on uninitialized memory#16052
acolombier merged 1 commit into
mixxxdj:2.5from
daschuer:valgrind_columncache

Conversation

@daschuer

Copy link
Copy Markdown
Member

This fixes this Valgrind finding:

==9950== Conditional jump or move depends on uninitialised value(s)
==9950==    at 0x49CE957: ColumnCache::slotSetKeySortOrder(double) (columncache.cpp:254)
==9950==    by 0xAFBB022: call (qobjectdefs_impl.h:375)
==9950==    by 0xAFBB022: void doActivate<false>(QObject*, int, void**) (qobject.cpp:3912)
==9950==    by 0x481E223: ControlProxy::valueChanged(double) (moc_controlproxy.cpp:167)
==9950==    by 0xAFBB022: call (qobjectdefs_impl.h:375)
==9950==    by 0xAFBB022: void doActivate<false>(QObject*, int, void**) (qobject.cpp:3912)
==9950==    by 0x4808779: valueChanged (moc_control.cpp:148)
==9950==    by 0x4808779: ControlDoublePrivate::setInner(double, QObject*) (control.cpp:291)
==9950==    by 0x4807382: ControlDoublePrivate::set(double, QObject*) (control.cpp:278)
==9950==    by 0x45774CB: set (controlproxy.h:139)
==9950==    by 0x45774CB: DlgPrefKey::loadSettings() (dlgprefkey.cpp:154)
==9950==    by 0x457AA37: DlgPrefKey::DlgPrefKey(QWidget*, QSharedPointer<ConfigObject<ConfigValue> >) (dlgprefkey.cpp:51)
==9950==    by 0x4566B4F: DlgPreferences::DlgPreferences(std::shared_ptr<mixxx::ScreensaverManager>, std::shared_ptr<mixxx::skin::SkinLoader>, std::shared_ptr<SoundManager>, std::shared_ptr<ControllerManager>, std::shared_ptr<VinylControlManager>, std::shared_ptr<EffectsManager>, std::shared_ptr<SettingsManager>, std::shared_ptr<Library>) (dlgpreferences.cpp:222)
==9950==    by 0x4549E12: MixxxMainWindow::initialize() (mixxxmainwindow.cpp:314)
==9950==    by 0xAFBB022: call (qobjectdefs_impl.h:375)
==9950==    by 0xAFBB022: void doActivate<false>(QObject*, int, void**) (qobject.cpp:3912)
==9950==    by 0xA5F0AD9: QOpenGLWindow::resizeEvent(QResizeEvent*) (qopenglwindow.cpp:665)
``

@daschuer daschuer added this to the 2.5.5 milestone Feb 27, 2026
@daschuer
daschuer force-pushed the valgrind_columncache branch from a7b9b1a to 8ccae29 Compare February 27, 2026 08:29

@acolombier acolombier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for addressing the issue

@acolombier
acolombier merged commit f1699ea into mixxxdj:2.5 Mar 1, 2026
28 of 29 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Releases Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants